K
> On 4 okt. 2013, at 22:15, Jeff Trawick <traw...@gmail.com> wrote: > >> On Fri, Oct 4, 2013 at 8:19 AM, Jeff Trawick <traw...@gmail.com> wrote: >>> On Fri, Oct 4, 2013 at 6:23 AM, Steffen <i...@apachelounge.com> wrote: >>> That looks better and so far I can see it is the behavior as with 2.3.7. >>> >>> Keep it running at AL. When I see some strange, I shall report. >> >> That is good news. I hope to tag and roll mod_fcgid 2.3.9 later in the day >> unless I hear of problems. > > Starting that now... > >> >>> >>> For your info, the build warnings: >> >> Yeah :( The whole stack from APR on up needs attention. For now I verified >> that they don't get worse between 2.3.7 and current svn sources. >> >>> warning C4267: 'function' : conversion from 'size_t' to 'DWORD', possible >>> loss of data >>> E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_proc_win.c 339 >>> warning C4267: 'function' : conversion from 'size_t' to 'DWORD', possible >>> loss of data >>> E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_proc_win.c 411 >>> warning C4267: 'function' : conversion from 'size_t' to 'int', possible >>> loss of data E:\VC11\Win64\2.4.6\include\http_protocol.h 414 >>> >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_bridge.c 69 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_bridge.c >>> 116 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_bridge.c >>> 121 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_pm_main.c 40 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_pm_main.c >>> 104 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_pm_main.c >>> 209 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_pm_main.c >>> 312 >>> warning C4244: '=' : conversion from '__int64' to 'int', possible loss of >>> data E:\VC11\Win64\2.4.6\modules\mod_fcgid-2.3.8\fcgid_proctbl_win.c 71 >>> >>> >>>> On Friday 04/10/2013 at 03:59, Jeff Trawick wrote: >>>>> On Thu, Oct 3, 2013 at 5:45 AM, Steffen <i...@apachelounge.com> wrote: >>>>> Running in real at AL for an hour with patch revert-r1377398.txt >>>>> >>>>> Results, see www.apachelounge.com/status-revert-r1377398.html >>>>> >>>>> Observation: >>>>> >>>>> No "hanging" with working and no accesses anymore >>>>> >>>>> Still quite some more processes: with 2.3.7 1-3 and now 8 >>>>> >>>>> Processes with idle time more then 300 (default) is still there, a >>>>> process has 1818 seconds and stays with 11 accesses and it does not >>>>> stop/kill. >>>>> >>>>> The diff with 2.3.7 that there are more entries with Process: >>>>> >>>>> In 2.3.7 I saw only one entry, never more: >>>>> >>>>> Process: php-cgi.exe (d:/servers/apache/php/php-cgi.exe) >>>>> .. >>>>> .. >>>>> .. >>>>> >>>>> As you can see in 2.3.8 more: >>>>> >>>>> Process: php-cgi.exe (d:/servers/apache/php/php-cgi.exe) >>>>> .. >>>>> .. >>>>> Process: php-cgi.exe (d:/servers/apache/php/php-cgi.exe) >>>>> ... >>>>> .. >>>>> etc. >>>>> >>>>> >>>>> >>>>> Back to 2.3.7 >>>> >>>> Steffen, thanks again for sticking with this. I've had trouble finding >>>> the time myself :( >>>> >>>> I've committed the last patch you tried, as well as one additional fix >>>> which could explain your latest results. (r1529062) >>>> >>>> Please try the latest from svn, or add this very minor change on top of >>>> the revert-r1377398.txt patch: >>>> >>>> http://svn.apache.org/viewvc/httpd/mod_fcgid/trunk/modules/fcgid/fcgid_pm_win.c?r1=1529062&r2=1529061&pathrev=1529062 >>>> >>>> These two uninitialized fields on Windows could prevent finding a >>>> suitable, existing FastCGI process when one is needed. (This was a >>>> regression in 2.3.8.) >>>> >>>> Thanks!!!!!! >>>> >>>>> >>>>> >>>>> >>>>> From: Jeff Trawick >>>>> Sent: Wednesday, October 2, 2013 2:10 AM >>>>> To: Apache HTTP Server Development List >>>>> Subject: Re: [VOTE] Release mod_fcgid 2.3.8 >>>>> >>>>> On Tue, Oct 1, 2013 at 6:57 PM, Jeff Trawick <traw...@gmail.com>wrote: >>>>>> On Tue, Oct 1, 2013 at 8:35 AM, Jeff Trawick <traw...@gmail.com> wrote: >>>>>>> On Sun, Sep 29, 2013 at 2:00 PM, Jeff Trawick <traw...@gmail.com> wrote: >>>>>>>> Tarballs/zips are at http://httpd.apache.org/dev/dist/mod_fcgid/ >>>>>>>> >>>>>>>> Shortcut to changes: >>>>>>>> http://httpd.apache.org/dev/dist/mod_fcgid/CHANGES-FCGID >>>>>>>> >>>>>>>> +/-1 >>>>>>>> [ ] Release mod_fcgid 2.3.8 as GA >>>>>>>> >>>>>>>> I'll hold the vote open for 72 hours unless something out of the >>>>>>>> ordinary occurs. >>>>>>> >>>>>>> This release is scrapped based on Steffen's test results. >>>>>>> >>>>>>> I know of one 2.3.8 change to back out that restores better behavior in >>>>>>> my testing, but we don't have a proposed fix for everything that >>>>>>> Steffen saw: >>>>>>> >>>>>>> - just one process is serving. >>>>>>> - rest is just “hanging” as working with no accesses and high idle >>>>>>> time. >>>>>>> >>>>>>> I suspect that all I can manage today is to move my test to Windows and >>>>>>> see if that behavior shows up. >>>>>> >>>>>> The previous patch I suggested was just a small bit of 1377398. I am >>>>>> testing a complete revert of that, as well as the two follow-up changes >>>>>> 1397778 and 1527358. With luck I'll even see Steffen's problem on >>>>>> Windows without it, but even if not I'll share the new one. >>>>> >>>>> >>>>>> >>>>>>>> >>>>>>>> Thanks in advance for testing! >>>>> >>>>> >>>>> Steffen, by chance can you test the full revert of r1377398 (and >>>>> follow-on fixes), at >>>>> >>>>> http://people.apache.org/~trawick/revert-r1377398.txt >>>>> >>>>> (CR-LF to make your GNU patch happy ;) ) >>>>> >>>>> I tested before and after on Windows using a trivial PHP script and >>>>> php-cgi.exe. I didn't see the issue Steffen saw, but it definitely used >>>>> a lot fewer processes after reverting. >>>>> >>>>> -- >>>>> Born in Roswell... married an alien... >>>>> http://emptyhammock.com/ >>>> >>>> >>>> >>>> -- >>>> Born in Roswell... married an alien... >>>> http://emptyhammock.com/ >> >> >> >> >> -- >> Born in Roswell... married an alien... >> http://emptyhammock.com/ > > > > -- > Born in Roswell... married an alien... > http://emptyhammock.com/
