My bad.. this is not against HEAD, this is Fedora 25. /sbin/httpd -v Server version: Apache/2.4.23 (Fedora) Server built: Jul 18 2016 15:38:14
Not so urgent for me now, but worth addressing I'd guess. On Mon, Nov 28, 2016 at 5:16 PM, William A Rowe Jr <wr...@rowe-clan.net> wrote: > Against 2.4 HEAD... > > In file included from mod_test_session.c:61:0: > mod_test_session.c: In function ‘test_session_register_hooks’: > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:128:36: > warning: the comparison will always evaluate as ‘true’ for the address of > ‘test_session_handler’ will never be NULL [-Waddress] > if (APACHE_HTTPD_TEST_HANDLER != NULL) \ > ^ > mod_test_session.c:348:1: note: in expansion of macro > ‘APACHE_HTTPD_TEST_MODULE’ > APACHE_HTTPD_TEST_MODULE(test_session); > ^~~~~~~~~~~~~~~~~~~~~~~~ > /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/apache_httpd_test.h:136:39: > warning: the comparison will always evaluate as ‘true’ for the address of > ‘test_session_init’ will never be NULL [-Waddress] > if (APACHE_HTTPD_TEST_CHILD_INIT != NULL) \ > ^ > mod_test_session.c:348:1: note: in expansion of macro > ‘APACHE_HTTPD_TEST_MODULE’ > APACHE_HTTPD_TEST_MODULE(test_session); > ^~~~~~~~~~~~~~~~~~~~~~~~ > > httpd: Syntax error on line 295 of /home/wrowe/dev/test/test24- > apr16-ossl102/t/conf/httpd.conf: Cannot load /home/wrowe/dev/test/test24- > apr16-ossl102/c-modules/test_session/.libs/mod_test_session.so into > server: /home/wrowe/dev/test/test24-apr16-ossl102/c-modules/test_ > session/.libs/mod_test_session.so: undefined symbol: ap_hook_session_save > > Does anyone have an uncommitted test framework patch > up their sleeve to remedy? > > TIA, > > Bill >