On Wed, Dec 14, 2016 at 2:51 AM, Joe Orton <jor...@redhat.com> wrote:
> On Tue, Dec 13, 2016 at 10:14:21AM -0500, Jim Jagielski wrote: > > > > > On Dec 13, 2016, at 8:33 AM, Jim Jagielski <j...@jagunet.com> wrote: > > > > > > This fails on all systems that have sed in /usr/bin/sed > > > or someplace other than /bin :( > > > > > > > Hmmm... even w/ the change to /usr/bin/sed I'm getting > > test #1 failing: > > Ah, sorry about that & thanks for adjusting the config. > > I adjusted the test case to cope with a sed which adds a trailing > newline now, does that pass with OS X sed? I'm yet to work out why the > test cases passes in trunk and fails in 2.4, mod_ext_filter is the same > in both branches. > Seeing different issues on Fedora 24 under 2.x and 2.4 branches, neither seems entirely good, 2.4 is especially strange. On 2.x branch, Test #2 fails with a failed to create process. # testing : slow filter process # expected: 'foobar' # received: '<!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> # <html><head> # <title>500 Internal Server Error</title> # </head><body> # <h1>Internal Server Error</h1> # <p>The server encountered an internal error or # misconfiguration and was unable to complete # your request.</p> # <p>Please contact the server administrator at # y...@example.com to inform them of the time this error occurred, # and the actions you performed just before this error.</p> # <p>More information about this error may be available # in the server error log.</p> # </body></html>' not ok 2 [Thu Dec 15 05:07:20.945238 2016] [example_hooks:notice] [pid 19326:tid 139620847179520] AH03297: x_create_connection() [Thu Dec 15 05:07:20.945327 2016] [example_hooks:notice] [pid 19326:tid 139620847179520] AH03297: x_create_request() [Thu Dec 15 05:07:20.945573 2016] [authz_core:debug] [pid 19326:tid 139620847179520] mod_authz_core.c(834): [client 127.0.0.1:49182] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:20.945603 2016] [charset_lite:debug] [pid 19326:tid 139620847179520] mod_charset_lite.c(216): [client 127.0.0.1:49182] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:20.945742 2016] [dialup:notice] [pid 19326:tid 139620847179520] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49182] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:20.981454 2016] [optional_hook_import:error] [pid 19326:tid 139620847179520] AH01866: Optional hook test said: GET /index.html HTTP/1.1 [Thu Dec 15 05:07:20.981473 2016] [optional_fn_export:error] [pid 19326:tid 139620847179520] AH01871: Optional function test said: GET /index.html HTTP/1.1 [Thu Dec 15 05:07:21.560737 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_connection() [Thu Dec 15 05:07:21.560806 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_request() [Thu Dec 15 05:07:21.560950 2016] [authz_core:debug] [pid 19326:tid 139620838786816] mod_authz_core.c(834): [client 127.0.0.1:49186] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:21.560967 2016] [charset_lite:debug] [pid 19326:tid 139620838786816] mod_charset_lite.c(216): [client 127.0.0.1:49186] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:21.561006 2016] [dialup:notice] [pid 19326:tid 139620838786816] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:21.572188 2016] [optional_hook_import:error] [pid 19326:tid 139620838786816] AH01866: Optional hook test said: GET /apache/extfilter/out-foo/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.572199 2016] [optional_fn_export:error] [pid 19326:tid 139620838786816] AH01871: Optional function test said: GET /apache/extfilter/out-foo/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.572237 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (9)Bad file descriptor: [client 127.0.0.1:49186] AH01466: apr_file_read(child output), len 18446744073709551615 [Thu Dec 15 05:07:21.572251 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (9)Bad file descriptor: [client 127.0.0.1:49186] AH01468: ef_unified_filter() failed [Thu Dec 15 05:07:21.572267 2016] [example_hooks:notice] [pid 19326:tid 139620838786816] AH03297: x_create_request() [Thu Dec 15 05:07:21.578555 2016] [authz_core:debug] [pid 19326:tid 139620838786816] mod_authz_core.c(834): [client 127.0.0.1:49186] AH01628: authorization result: granted (no directives) [Thu Dec 15 05:07:21.578578 2016] [charset_lite:debug] [pid 19326:tid 139620838786816] mod_charset_lite.c(216): [client 127.0.0.1:49186] AH01448: incomplete configuration: src unspecified, dst unspecified [Thu Dec 15 05:07:21.578616 2016] [dialup:notice] [pid 19326:tid 139620838786816] (70023)This function has not been implemented on this platform: [client 127.0.0.1:49186] AH02637: dialup: MPM doesn't support suspending [Thu Dec 15 05:07:21.578683 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (2)No such file or directory: [client 127.0.0.1:49186] AH01458: couldn't create child process to run `/home/wrowe/dev/test/test2x-apr20-ossl110/t/htdocs/modules/ext_filter/ sleepycat.pl' [Thu Dec 15 05:07:21.578690 2016] [ext_filter:error] [pid 19326:tid 139620838786816] (2)No such file or directory: [client 127.0.0.1:49186] AH01467: can't initialise output filter sleepy-cat-out: aborting [Thu Dec 15 05:07:21.578801 2016] [optional_hook_import:error] [pid 19326:tid 139620838786816] AH01866: Optional hook test said: GET /apache/extfilter/out-slow/foobar.html HTTP/1.1 [Thu Dec 15 05:07:21.578806 2016] [optional_fn_export:error] [pid 19326:tid 139620838786816] AH01871: Optional function test said: GET /apache/extfilter/out-slow/foobar.html HTTP/1.1 ossl110/t/htdocs/modules/ext_filter/sleepycat.pl' ... I presumed maybe a missing perl cpan component, perhaps it is... On 2.4 branch, everything seems to go sideways; t/modules/ext_filter.t .............. 1/24 # Failed test 2 in t/modules/ext_filter.t at line 26 # Failed test 5 in t/modules/ext_filter.t at line 36 # Failed test 6 in t/modules/ext_filter.t at line 37 # Failed test 7 in t/modules/ext_filter.t at line 36 fail #2 # Failed test 8 in t/modules/ext_filter.t at line 37 fail #2 # Failed test 9 in t/modules/ext_filter.t at line 36 fail #3 # Failed test 10 in t/modules/ext_filter.t at line 37 fail #3 # Failed test 11 in t/modules/ext_filter.t at line 36 fail #4 # Failed test 12 in t/modules/ext_filter.t at line 37 fail #4 # Failed test 13 in t/modules/ext_filter.t at line 36 fail #5 # Failed test 14 in t/modules/ext_filter.t at line 37 fail #5 # Failed test 15 in t/modules/ext_filter.t at line 36 fail #6 # Failed test 16 in t/modules/ext_filter.t at line 37 fail #6 # Failed test 17 in t/modules/ext_filter.t at line 36 fail #7 # Failed test 18 in t/modules/ext_filter.t at line 37 fail #7 # Failed test 19 in t/modules/ext_filter.t at line 36 fail #8 # Failed test 20 in t/modules/ext_filter.t at line 37 fail #8 # Failed test 21 in t/modules/ext_filter.t at line 36 fail #9 # Failed test 22 in t/modules/ext_filter.t at line 37 fail #9 # Failed test 23 in t/modules/ext_filter.t at line 36 fail #10 # Failed test 24 in t/modules/ext_filter.t at line 37 fail #10 t/modules/ext_filter.t .............. Failed 21/24 subtests I don't see anything else wrong on 2.4 branch except for t/modules/rewrite.t ................. 1/34 # Failed test 34 in t/modules/rewrite.t at line 120 t/modules/rewrite.t ................. Failed 1/34 subtests (1 TODO test unexpectedly succeeded) But I have not yet caught up with the latest commits to rewrite. Thinking that on 2.4 branch, a poorly performing retest against 2.4.23 is all that is needed to proceed to release, and then return to address later as not-a-regression.
