Doesn't this simply gloss over an underlying defect?
[...]
if (apr_dbm_fetch(f, key, &val) == APR_SUCCESS && val.dptr) {
*value = apr_pstrmemdup(pool, val.dptr, val.dsize);
}
apr_dbm_close(f);
return rv;
}
Shouldn't we capture and return the failure code from apr_dbm_fetch here?
On Wed, Jan 9, 2019 at 3:34 AM <jor...@apache.org> wrote:
> Author: jorton
> Date: Wed Jan 9 09:34:34 2019
> New Revision: 1850835
>
> URL: http://svn.apache.org/viewvc?rev=1850835&view=rev
> Log:
> * modules/aaa/mod_authn_dbm.c (fetch_dbm_value): No functional change:
> return APR_SUCCESS rather than rv, which is guaranteed to be
> APR_SUCCESS in current code.
>
> Modified:
> httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c
>
> Modified: httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c?rev=1850835&r1=1850834&r2=1850835&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c (original)
> +++ httpd/httpd/trunk/modules/aaa/mod_authn_dbm.c Wed Jan 9 09:34:34 2019
> @@ -101,7 +101,7 @@ static apr_status_t fetch_dbm_value(cons
>
> apr_dbm_close(f);
>
> - return rv;
> + return APR_SUCCESS;
> }
>
> static authn_status check_dbm_pw(request_rec *r, const char *user,
>
>
>
