On Thu, Jan 20, 2022 at 1:53 PM Ruediger Pluem <rpl...@apache.org> wrote: > > On 1/20/22 12:09 PM, yla...@apache.org wrote: > > > > #include "httpd.h" > > +#include "apr_version.h" > > Why is this needed?
It's not (anymore), I tested for APR_VERSION_AT_LEAST(1,8,0) previously. > > > +#include "apr_portable.h" > > apr_thread_proc.h > > is not sufficent? It is, same remnant from an older version using the apr_threadkey API still. > > > + > > +#ifdef HAVE_PCRE2 > > + *ovector = pcre2_get_ovector_pointer(tls->data); > > +#else > > + *vector = tls->data; > > *ovector instead of *vector? Clearly, I thought I had compile tested first with PCRE1 and !APR_HAS_THREAD_LOCAL but made changes afterward.. > > > + > > +#ifdef HAVE_PCRE2 > > + data = pcre2_match_data_create(size, NULL); > > + *ovector = pcre2_get_ovector_pointer(data); > > Should we do an if (data) here? Not sure if pcre2_get_ovector_pointer can > work with NULL PCRE2 assumes !NULL so clearly! All good points, thanks Rüdiger, should be fixed in r1897250. Regards; Yann.
