Christoph Kiehl wrote: ------------------------------ As far as I can see the following needs to be done:
In LuceneQueryBuilder methods need to be extracted for a) creating Terms b) creating WildcardQueries c) creating MatchAllQueries If you just pass the a flag to LuceneQueryBuilder for the beginning you need one "if (newFormat)" in each method. In NodeIndexer you need one "if (newFormat)" in createFieldWithoutNorms() and one where you need to decide whether to add the new PROPERTY_SET field. In SearchIndex a different SortComparator needs to be used in createSortFields(). Means six checks in total. I would go for the easy way in the beginning. We can still extract the code into classes. I would like to see it working first before doing the refactoring. WDYT? --------------------------------- I can live with this :-) I'll file a jira issue tomorrow and keep my you posted. Regards Ard and thanks for the pointers ps stupid webmail...makes indenting pretty harsh :-)
