[ 
https://issues.apache.org/jira/browse/JCR-3732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13930750#comment-13930750
 ] 

Dominique Pfister commented on JCR-3732:
----------------------------------------

[~shgupta], thank you for providing a patch, looks fine, apart from the literal 
"s3EndPoint": other property names are listed as static strings in S3Constants, 
any reason why you didn't do the same for "s3EndPoint"?

> Externalize S3 endpoints
> ------------------------
>
>                 Key: JCR-3732
>                 URL: https://issues.apache.org/jira/browse/JCR-3732
>             Project: Jackrabbit Content Repository
>          Issue Type: Sub-task
>          Components: jackrabbit-core
>    Affects Versions: 2.7.4
>            Reporter: Shashank Gupta
>             Fix For: 2.7.5
>
>         Attachments: JCR-3732.patch
>
>
> Currently S3 connector uses S3 region ( already externalized via 
> aws.properties) to configure S3 endpoint as per the mapping [1].
> There are cases where single S3 region may contains multiple endpoints. for 
> e. US Standard region has two endpoints:
> s3.amazonaws.com (Northern Virginia or Pacific Northwest)
> s3-external-1.amazonaws.com (Northern Virginia only)
> To handle these cases, S3 connector should externalize endpoint configuration 
> (as optional) and has higher precedence over endpoint derived via S3 region.
> [1]
> http://docs.aws.amazon.com/general/latest/gr/rande.html#s3_region



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to