Some repeated comments:
* use TestNG assertions only, at least in new test code (rather than Java
`assert`s)?
* plenty of cases where assertions in a test are surrounded by `if
(allResults.size() >= 1) { ... }`. Are we legitimately expecting no responses
here? If so, at least throw a SkipException, rather than simply having a test
succeed, even though no assertions were actually run?
* some test classes seem to make the tests package-level `void`? Use `public
void` as in most other tests?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/194#issuecomment-27935365
