> +import java.beans.ConstructorProperties;
> +
> +import static com.google.common.base.Preconditions.checkNotNull;
> +import static 
> org.jclouds.openstack.v2_0.options.PaginationOptions.Builder.marker;
> +
> +/**
> + * @author Nick Livens
> + */
> +@Beta
> +@Singleton
> +public class ParseRouterDetails extends ParseJson<Routers> {
> +   static class Routers extends PaginatedCollection<Router> {
> +
> +      @ConstructorProperties({ "routers", "routers_links" })
> +      protected Routers(Iterable<Router> routers, Iterable<Link> 
> routers_links) {
> +         super(routers, routers_links);

If we're going to use `@ConstructorProperties` here, I think we can use "Java" 
names for the actual vars? I.e. `routerLinks` or `routersLinks` rather than 
`routers_links`

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/47/files#r7546872

Reply via email to