> @@ -78,7 +81,7 @@ protected void configure() {
>        // bit before the deadline to make sure there aren't session 
> expiration exceptions
>        sessionIntervalInSeconds = sessionIntervalInSeconds > 30 ? 
> sessionIntervalInSeconds - 30 :
>                sessionIntervalInSeconds;
> -      return 
> CacheBuilder.newBuilder().expireAfterWrite(sessionIntervalInSeconds, 
> TimeUnit.MINUTES).build(CacheLoader
> +      return 
> CacheBuilder.newBuilder().expireAfterWrite(sessionIntervalInSeconds, 
> TimeUnit.SECONDS).build(CacheLoader

Not sure I'm getting this: in the updated Javadoc, we explicitly state that the 
time configured _here_ is **not** related to the `expires_in` parameter (which, 
as per documentation, is in seconds).

Is the change to seconds here motivated by that piece of Google documentation? 
Or do we think `sessionIntervalInSeconds, TimeUnit.MINUTES` is simply a bug, 
which is indeed what it looks like, from the variable names, at least?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/14/files#r7587601

Reply via email to