> @@ -111,16 +147,12 @@ public void 
> testLocationPredicateWhenComputeMetadataIsNotLocationBound() {
>     }
>     
>     @SuppressWarnings("unchecked")
> -   @Test
> -   public void testResolveImages() {
> -
> -
> +   protected void doTestResolveImages(Supplier<Set<? extends Image>> images, 
> Image expectedBest, 
> +           Function<TemplateBuilderImpl, TemplateBuilderImpl> 
> builderCustomisation) {

This new style makes the test very hard to understand...what does the 
`builderCustomisation` do..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/202/files#r7621149

Reply via email to