> @@ -153,8 +154,10 @@ protected EC2ComputeService(ComputeServiceContext 
> context, Map<String, Credentia
>  
>        if (client.getTagApiForRegion(region).isPresent()) {
>           Map<String, String> common = 
> metadataAndTagsAsValuesOfEmptyString(template.getOptions());
> -         if (common.size() > 0 || generateInstanceNames) {
> -            return addTagsToInstancesInRegion(common, nodes, region, group);
> +         if (common.size() > 0 || 
> !template.getOptions().getNodeNames().isEmpty()
> +                 || generateInstanceNames) {

`!common.isEmpty()`? And have `generateInstanceNames` first as I guess it'll be 
cheaper to check..?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/206/files#r7710426

Reply via email to