> @@ -153,8 +155,9 @@ protected EC2ComputeService(ComputeServiceContext
> context, Map<String, Credentia
>
> if (client.getTagApiForRegion(region).isPresent()) {
> Map<String, String> common =
> metadataAndTagsAsValuesOfEmptyString(template.getOptions());
> - if (common.size() > 0 || generateInstanceNames) {
> - return addTagsToInstancesInRegion(common, nodes, region, group);
> + if (generateInstanceNames || !common.isEmpty() ||
> !template.getOptions().getNodeNames().isEmpty()) {
Didn't think about this last time, but is this intended to be `||` rather than
`&&`? In that case, if `generateInstanceNames` is true but `common` and/or
`template.getOptions().getNodeNames()` are empty, would
`addTagsAndNamesToInstancesInRegion` work?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/206/files#r7782862
