> +         authenticatedGET().endpoint(endpoint + 
> "/routers").addQueryParam("fields", "id", "tenant_id", "name").build(),
> +         
> HttpResponse.builder().statusCode(200).payload(payloadFromResourceWithContentType("/list_routers.json",
>  APPLICATION_JSON)).build())
> +         .getRouterExtensionForZone(ZONE).get();
> +
> +      Set<? extends ReferenceWithName> references = 
> api.list().concat().toSet();
> +      assertEquals(references, listOfReferencesWithNames());
> +   }
> +
> +   public void testListReferencesReturns4xx() {
> +      RouterApi api = requestsSendResponses(
> +         keystoneAuthWithUsernameAndPasswordAndTenantName, 
> responseWithKeystoneAccess,
> +         authenticatedGET().endpoint(endpoint + 
> "/routers").addQueryParam("fields", "id", "tenant_id", "name").build(),
> +         HttpResponse.builder().statusCode(404).build())
> +         .getRouterExtensionForZone(ZONE).get();
> +
> +      assertTrue(api.list().concat().isEmpty());

What exactly do you mean by this messages? Because from the code you can tell 
we will get a 404 HTTP response. And then we test the fact to see if the 
specified fallback is working as expected. Should I include such messages on 
each expected test failure?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-openstack/pull/47/files#r8019270

Reply via email to