Hi Robert,
how would you change this?
Kind regards
Karl-Heinz Marbaise
On 10/2/14 8:22 PM, Robert Scholte wrote:
Hi Dennis, Karl-Heinz,
the issue mentioned compatibility and based on the changes it looked to
me that the intention doesn't match the actual behavior in the end.
With plugins it is very easy to force a specific version of Maven: set
the prerequisite.
*If* the idea was that changing the maven dependency version in
shared-utils to 2.2.1 would help us to push users towards newer versions
of Maven, then that idea was not correct.
It is possible, if you specify the dependency like:
<dependency>
<groupId>org.apache.maven</groupId>
<artifactId>maven-toolchain</artifactId>
<version>[2.2.1,)</version>
<scope>provided</scope>
</dependency>
The downside of this construction is that the project using shared-utils
is now responsible to specify the preferred version, otherwise the
latest will be used.
If this change is just about housekeeping, that's fine too. But then the
issue text is misleading.
I hope this clears things up :)
Robert
Op Tue, 30 Sep 2014 13:43:06 +0200 schreef Dennis Lundberg
<denn...@apache.org>:
Hi Robert,
Isn't the idea of the work Karl-Heinz is doing to unify the version of
maven core libraries in our other components/plugins?
It is true that the mavenVersion property has a dual meaning:
1. setting a prerequisite for the version of Maven required to build
the project
2. setting the version of dependencies on maven core components
IIUC Karl-Heinz is mainly trying to solve 2 by changing the value of
mavenVersion. We have already in our docs that we require at least
Maven 2.2.1 to build our projects, and in some cases (site) Maven
3.0.5. I don't see any negative sideeffect of changing the
mavenVersion property. Perhaps I am missing something?
When Karl-Heinz has finished upgrading to 2.2.1 everywhere, why would
anyone want to redefine the preferred version to an earlier verion
like 2.0.9? I can't think of a way to prevent that.
Introducing a version range like [2.2.1,) for the prerequisites
doesn't change anything as I understand it.
On Sat, Sep 27, 2014 at 10:58 PM, Robert Scholte
<rfscho...@apache.org> wrote:
Hi,
I wonder if this does what we want to achieve: forcing projects using
maven-shared-utils to be executed with at least Maven 2.2.1.
Right now it is just the preferred version, no problem if the project
itself
redefines it to 2.0.9 for instance.
Is that a problem or should we say [2.2.1,) ?
thanks,
Robert
Op Sat, 27 Sep 2014 22:30:03 +0200 schreef <khmarba...@apache.org>:
Author: khmarbaise
Date: Sat Sep 27 20:30:03 2014
New Revision: 1628003
URL: http://svn.apache.org/r1628003
Log:
[MSHARED-359]
- Upgrade to Maven 2.2.1 build and compatibility.
Modified:
maven/shared/trunk/maven-shared-utils/pom.xml
Modified: maven/shared/trunk/maven-shared-utils/pom.xml
URL:
http://svn.apache.org/viewvc/maven/shared/trunk/maven-shared-utils/pom.xml?rev=1628003&r1=1628002&r2=1628003&view=diff
==============================================================================
--- maven/shared/trunk/maven-shared-utils/pom.xml (original)
+++ maven/shared/trunk/maven-shared-utils/pom.xml Sat Sep 27
20:30:03 2014
@@ -55,7 +55,7 @@
</distributionManagement>
<properties>
- <mavenVersion>2.1.0</mavenVersion>
+ <mavenVersion>2.2.1</mavenVersion>
</properties>
<dependencies>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
