Github user Tibor17 commented on a diff in the pull request:
https://github.com/apache/maven-surefire/pull/120#discussion_r78351427
--- Diff:
surefire-integration-tests/src/test/java/org/apache/maven/surefire/its/fixture/HelperAssertions.java
---
@@ -159,4 +164,10 @@ public static IntegrationTestSuiteResults
parseReportList( List<ReportTestSuite>
throw new RuntimeException( "Couldn't parse XML reports", e );
}
}
+
+ public static void assumeJavaVersion(JavaVersion version)
+ {
+ assumeThat( "java.specification.version: ",
+ SystemUtils.JAVA_SPECIFICATION_VERSION, is(
greaterThanOrEqualTo( version.toString() ) ) );
--- End diff --
I would not use JDK 9 for such simple comparison.
Back to `SystemUtils.JAVA_SPECIFICATION_VERSION, is( greaterThanOrEqualTo(
version.toString() ) ) );`
It's matter of taste if you just compare strings or float numbers.
Comparing float numbers would make me sleep better.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
