Github user khmarbaise commented on a diff in the pull request: https://github.com/apache/maven/pull/119#discussion_r117611940 --- Diff: maven-model-builder/src/test/java/org/apache/maven/model/validation/DefaultModelValidatorTest.java --- @@ -604,17 +609,21 @@ public void testBadImportScopeClassifier() "'dependencyManagement.dependencies.dependency.classifier' for test:a:pom:cls must be empty" ); } - public void testSystemPathRefersToProjectBasedir() + public void testSystemPathRefersToProjectBasedirAndDeprecatedScope() --- End diff -- I think it's better having different test cases. Keeping the old test cases and create new ones for the changed behaviour. That makes it safe not to break previous behaviour,
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org