Michael, I will split SUREFIRE-1380 in two tickets on tomorrow evening. Another flush is necessary because the method InputStream.read() is called in a loop and the flush should be called after last byte. If another thread marks the stream to be closed asynchronously, then the bytes can be lost. Therefore flushing if stream has been closed in the intermediate time between these two threads. Maybe not clear to understand, we can have a look deeper.
On Sat, Jun 3, 2017 at 12:31 PM, Tibor Digana <tibor.dig...@googlemail.com> wrote: > The changes in SUREFIRE-1376 are done. > > On Sat, Jun 3, 2017 at 11:52 AM, Michael Osipov <micha...@apache.org> > wrote: > >> Am 2017-06-03 um 10:56 schrieb Tibor Digana: >> >>> I have added a new branch with small change only, SUREFIRE-1380. >>> https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git >>> ;a=shortlog;h=refs/heads/SUREFIRE-1380 >>> >> >> I am not happy with this: you mix two different taks in one issue, >> refactoring and flush. There is no explanation why another flush is >> necessary or what the benefit will be, i.e., don't fix things which aren't >> broken. >> >> WDYT? >> >> >> Michael >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org >> For additional commands, e-mail: dev-h...@maven.apache.org >> >> > > > -- > Cheers > Tibor > -- Cheers Tibor
