Github user Tibor17 commented on a diff in the pull request:

    https://github.com/apache/maven-surefire/pull/157#discussion_r125169671
  
    --- Diff: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ---
    @@ -847,12 +847,33 @@ private DefaultScanResult scanDependencies()
             {
                 try
                 {
    +                DefaultScanResult scanResult = new DefaultScanResult( 
Collections.EMPTY_LIST );
    +                
    +                List<String> dependenciesToScanList = new ArrayList( 
Arrays.asList( getDependenciesToScan() ) );
    +                TestListResolver includedAndExcludedTests = 
getIncludedAndExcludedTests();
    +
    +                for ( MavenProject mavenProject : 
session.getSortedProjects() )
    +                {
    +                    String groupArtifactId = new StringBuilder( 
mavenProject.getGroupId() ).append( ":" )
    --- End diff --
    
    Pls concatenate as follows `mavenProject.getGroupId() + ":" + 
mavenProject.getArtifactId()`.
    This is simple and `javac` would compile to StringBuilder anyway, but 
longer in sources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org

Reply via email to