Github user Tibor17 commented on the issue: https://github.com/apache/maven-surefire/pull/160 If you plan a new commit, pls do not create two. Amend the previous one. Thx. On Tue, Jul 25, 2017 at 5:29 PM, Tibor Digana <tibor.dig...@googlemail.com> wrote: > Pls check it together with documentation of param "forkMode". I think > threadCount can be used with forkMode as well. > > On Tue, Jul 25, 2017 at 4:24 PM, Matous Jobanek <notificati...@github.com> > wrote: > >> Otherwise, the TestNG fails with >> Cannot use a threadCount parameter less than 1; 1 > 0 >> in some cases when the parallel parameter was not set. To identify the >> cases, take a look at related Jira issue: https://issues.apache.org/jira >> /browse/SUREFIRE-1398 >> I removed the check for positiveness of the threadCount value as it's a >> responsibility of the user to provide correct value. >> The question is if the default value of threadCount parameter shouldn't >> be 1, to avoid such a problems...? If yes, then I'll update my PR >> ------------------------------ >> You can view, comment on, or merge this pull request online at: >> >> https://github.com/apache/maven-surefire/pull/160 >> Commit Summary >> >> - SUREFIRE-1398 Sets threadCount only when parallel parameter is set >> >> File Changes >> >> - *M* maven-surefire-common/src/main/java/org/apache/maven/plugin/ >> surefire/AbstractSurefireMojo.java >> <https://github.com/apache/maven-surefire/pull/160/files#diff-0> (13) >> >> Patch Links: >> >> - https://github.com/apache/maven-surefire/pull/160.patch >> - https://github.com/apache/maven-surefire/pull/160.diff >> >> â >> You are receiving this because you are subscribed to this thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/maven-surefire/pull/160>, or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AA_yR4lRkgmqVWg76yDzf07EhQ9kTSotks5sRfqfgaJpZM4OioY5> >> . >> > > > > -- > Cheers > Tibor > -- Cheers Tibor
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org For additional commands, e-mail: dev-h...@maven.apache.org