Hi,
Isn't the line "Unable to find the root directory. Create a .mvn directory
in the root directory or add the root="true" attribute on the root
project's model to identify it." unexpected (at least not being printed
with a logger even if I get it is pre-java world, output is quite weirdish.
We still have warning for not pinned versions - think it was fixed on 3.9
("[WARNING] Version not locked for default bindings plugins
[maven-resources-plugin, maven-surefire-plugin, maven-jar-plugin], you
should define versions in pluginManagement section of your pom.xml or
parent").
Rest is ok, compared to last one only the new not log line is question to
debate since it will miss integrations so should either be done in java
later if the prop is not set or not done at all IMHO.
Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> | Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>
Le dim. 25 juin 2023 à 14:59, Guillaume Nodet <gno...@apache.org> a écrit :
> Le dim. 25 juin 2023 à 12:33, Karl Heinz Marbaise <khmarba...@gmx.de> a
> écrit :
>
> > Hi,
> >
> > I've tested several projects with it and also in relationship with Maven
> > 3.9.X..
> >
> > The same as in Maven 3.9.3 .. plugins used which have issues like the
> > maven-site-plugin (3.12.1) and being reported via
> > `-Dmaven.plugin.validation=VERBOSE` (in Maven 3.9.3) will not produce
> > even a hint in Maven 4.0.0-alpha-7 without the supplemental parameter
> > "-Dmaven.plugin.validation=VERBOSE"
> >
> > My opinion is to report such plugins in Maven 4 always to make sure
> > people and more important plugin maintainers/author becoming aware of
> > possible issues...or maybe reporting it already in 3.9.3 as well as in
> > Maven 4.X
> >
> > Furthermore related to https://issues.apache.org/jira/browse/MNG-7228
> > rechecked and confirming that it now works.
> >
> > https://issues.apache.org/jira/browse/MNG-7604
> > * We have now surefire/failsafe 3.X versions related to pom.*
> > interpolations. We might think about failing the build if finding such
> > things????
> >
> > * MNG-5600 Dependency management import should support exclusions.
> >
> > From my point of view this means we have to change the model version
> > because that can technically being read by Maven 3.X but it simply will
> > not work at all.
> >
>
> Shouldn't that be validated and fail in 3.x ?
>
>
> >
> > * MNG-7805 This means we introduce NS but Maven 3.X can not read it
> > anymore. That requires modelVersion change to fail Maven 3.X very early
> > (Also XSD has to be changed for tools/IDE's etc.)
> > I don't know how Maven 3.X behaves in cases of NS in the XML
> >
>
> I don't understand, this is not different from other build/consumer poms
> features.
> The xsd can still be used to validate those build poms, but yes, they can
> only be used on maven 4.
> See below
>
>
> >
> > * Also found that the hint at the beginning of Maven 4 build:
> >
> > "Unable to find the root directory. Create a .mvn directory in the root
> > directory or add the root="true" attribute on the root project's model
> > to identify it."
> >
> > If I add that attribute to the `<project type="root" .." this resulting
> > project fails with Maven 3... which means that it requires a model
> > version change...including an XSD change (required for tools, IDE's etc)
> > !! It must be clear for users having a Maven 4 pom in front of them or a
> > Maven 3 pom file ...
> >
>
> Well, that's related to the discussions on the model version. I do agree
> it's a bad idea to add attributes or elements to the model and not version
> the schema, but it seems it has been agreed on and has been done a couple
> of times in the past 10 years or so.
>
> The build/consumer pom could be an opt-in with a new 4.1.0 model version,
> which would make it clear that such projects now require Maven 4. This
> cannot be done by changing the namespace only, as if you change your xml
> namespace to 4.1.0, maven 3.x will not complain, as it simply ignores the
> namespace.
>
> Please have a look https://github.com/apache/maven/pull/1160.
>
>
>
> >
> > Othwise +1 from me.
> >
> > Kind regards
> > Karl Heinz Marbaise
> >
> >
> > On 24.06.23 12:56, Guillaume Nodet wrote:
> > > I'm starting a new vote to release this new alpha.
> > >
> > > 67 issues solved:
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922&version=12353052
> > >
> > > Staging repository:
> > > https://repository.apache.org/content/repositories/maven-1970
> > >
> > > Dev dist directory:
> > > https://dist.apache.org/repos/dist/dev/maven/maven-4/4.0.0-alpha-7/
> > >
> > > Source release checksums:
> > > apache-maven-4.0.0-alpha-6-src.zip sha512:
> > >
> > >
> >
> bc822a381f84b156f2d5c2b59502db44ef3e8689f534913820dc0c68014e02dc75639c1990df4203d7923318d2b1668b050f452556c15eb638271e1ae3688e87
> > >
> > > apache-maven-4.0.0-alpha-6-src.tar.gz sha512:
> > >
> > >
> >
> c7e9d13df74797163e816536e76f14c25496cdc8f13faa990bf14ce5a5669ec09cdc44dd4da866dd72d68ba9e2d8d6bdcce57110e21ecbeb8d15c50cad64430b
> > >
> > >
> > > Binary release checksums:
> > > apache-maven-4.0.0-alpha-6-bin.zip sha512:
> > >
> > >
> >
> ec47b84cbf5dd85a8081d218bf105d4664e298d906c28f11192bf563f30087a4d898f872fc73230391579f8aa84e70bddb0ae2eabc42b53a2c574d5793ceb1a2
> > >
> > > apache-maven-4.0.0-alpha-6-bin.tar.gz sha512:
> > >
> > >
> >
> 9959e537712167094a7909006168404c16b0788862311ef65840f57777b8d3afc519e63262b064db7361bc6ef77940bed14ead5e0a59d135bcdeea83be4d9893
> > >
> > >
> > > Staged site:
> > > https://maven.apache.org/ref/4-LATEST/
> > >
> > > Draft for release notes:
> > > https://github.com/apache/maven-site/pull/432
> > >
> > > Guide to testing staged releases:
> > > http://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for 72h
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > >
> >
> > Mit freundlichem Gruß
> > Karl Heinz Marbaise
> > --
> > SoftwareEntwicklung Beratung Schulung Tel.: +49 (0) 2405 / 415 893
> > Inhaber Dipl.Ing.(FH) Karl Heinz Marbaise USt.IdNr: DE191347579
> > Hauptstrasse 177
> > 52146 Würselen https://www.soebes.de
> >
> >
>
> --
> ------------------------
> Guillaume Nodet
>
