On Thu, 31 Oct 2013 00:20:27 +0100
"Bernd Eckenfels" <e...@zusammenkunft.net> wrote:
> Am 31.10.2013, 00:06 Uhr, schrieb Olivier Lamy <ol...@apache.org>:
> > On 31 October 2013 08:01, <tche...@apache.org> wrote:
> >> + @Parameter( property = "maven.rar.skip" )
> >> + private boolean skip;
>
> Does it make sense to add a expression="${maven.rar.skip}" (or maybe
> ${skipMavenRar}?). Especially the skip function is usefull from the
> command line.
Hum I follow the *convention* used by other plugins :
maven.test.skip
maven.javadoc.skip
maven.install.skip
...
>
> Bernd
>
> >> + if ( skip )
> >> + {
> >> + getLog().info( "Skipping rar generation." );
> >> + }
> >> +
> >
> > really skipping? :-)
> >
> >> getLog().debug( " ======= RarMojo settings =======" );
> >> getLog().debug( "rarSourceDirectory[" + rarSourceDirectory +
> >> "]" );
> >> getLog().debug( "manifestFile[" + manifestFile + "]" );
>
> Is there a best practise for printing parameters before or after early
> return?
I don't know
tony.
--
Tony Chemit
--------------------
tél: +33 (0) 2 40 50 29 28
http://www.codelutin.com
email: che...@codelutin.com
twitter: https://twitter.com/tchemit
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
