----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14057/#review26010 -----------------------------------------------------------
Ship it! Patch looks good! Also gave this a quick test on our staging cluster, and it appeared to work as intended. - Brenden Matthews On Sept. 10, 2013, 2:28 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14057/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2013, 2:28 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Bugs: MESOS-680 > https://issues.apache.org/jira/browse/MESOS-680 > > > Repository: mesos-git > > > Description > ------- > > We have seen cases where a slave could die after opening a file but before > writing anything to it. This fix considers them as acceptable. > > > Diffs > ----- > > src/slave/state.cpp c03db32156c49a1b99998f147325d9e43686c396 > > Diff: https://reviews.apache.org/r/14057/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >