> On Oct. 1, 2013, 4:49 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/hostport.hpp, line 51 > > <https://reviews.apache.org/r/14400/diff/2/?file=359576#file359576line51> > > > > Please use braces.
oops. copy paste error from pid.cpp. will fix that one too. > On Oct. 1, 2013, 4:49 p.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/include/process/hostport.hpp, line 126 > > <https://reviews.apache.org/r/14400/diff/2/?file=359576#file359576line126> > > > > We should probably pull all this into a helper, perhaps add a TODO? added a todo. - Vinod ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14400/#review26565 ----------------------------------------------------------- On Sept. 30, 2013, 2:45 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14400/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2013, 2:45 a.m.) > > > Review request for mesos, Benjamin Hindman and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 130d40c3301bc6ffa6d8e531e48d8d9406a61cf7 > 3rdparty/libprocess/include/process/hostport.hpp PRE-CREATION > 3rdparty/libprocess/src/tests/hostport_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/14400/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
