----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15198/#review28299 -----------------------------------------------------------
Looks good, but how does this affect people who don't use flash? I, for example, only use flash on an opt-in basis. I have it disabled by default unless I need to explicitly enable it. - Brenden Matthews On Nov. 2, 2013, 8:41 p.m., Ross Allen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15198/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2013, 8:41 p.m.) > > > Review request for mesos. > > > Repository: mesos-git > > > Description > ------- > > Added a flash service for UI alerts after redirects. > > When an error occurs during a redirect, it is useful to show an error > message on the following page view rather than the current one. In > particular, when clicking a sandbox link for a slave that is > inaccessible, the `SlaveExecutorRerouterCtrl` sends a request to the > desired slave and redirects back to root if an error occurs. It's not > possible to show an error during the redirect, and so rendering on > the root view is ideal. > > Flash alerts are rendered once and then cleaned up; they will not > display more than once. > > Review: http://reviews.apache.org/r/15198 > > > Diffs > ----- > > src/Makefile.am 9780d07a23ca196c541a44a85499c2f44a574b9c > src/webui/master/static/index.html 47403d8dc407a454e011262d3614197e49f159ca > src/webui/master/static/js/app.js b918799c0ce82f9427143161cb0bccaed63b9557 > src/webui/master/static/js/controllers.js > 0c930a2101af2d95bd003d8860602f9e3dd26fba > src/webui/master/static/js/services.js PRE-CREATION > > Diff: https://reviews.apache.org/r/15198/diff/ > > > Testing > ------- > > Ran `make` and `make check` > > Started a slave > Started a framework + task on the slave > Killed the slave > Clicked the sandbox link from task > Verified the flash alert displayed after the redirect > > > File Attachments > ---------------- > > Sample error after dead sandbox link click > > https://reviews.apache.org/media/uploaded/files/2013/11/02/Screen_Shot_2013-11-02_at_10.09.51_AM.png > > > Thanks, > > Ross Allen > >
