----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/16038/#review29812 -----------------------------------------------------------
Ship it! Good catch! - Brenden Matthews On Dec. 5, 2013, 8:45 a.m., Ben Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/16038/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2013, 8:45 a.m.) > > > Review request for mesos, Benjamin Hindman, Brenden Matthews, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > This was discovered in 0.16.0-rc1, https://reviews.apache.org/r/14434/ causes > the master to raise an exception when there are no statuses available > (pre-0.16.0 slave will not have any statuses when it re-registers with the > master). > > I'm not convinced this is the only case where this can occur, since we do not > always insert a status in Tasks, so I'm making this condition explicit to > prevent this exception. We should take up a subsequent change to ensure that > a status is always inserted for each state (we don't do this for STAGING in > some places). > > > Diffs > ----- > > src/master/master.cpp 4f4db93a3c66d79e25783c7ea0617f5cf807c1aa > src/slave/slave.cpp 75d9e5dfce9f546fb528d9f0fcf8ba127ac40b9c > > Diff: https://reviews.apache.org/r/16038/diff/ > > > Testing > ------- > > make check (I did not add a test here because the known case that triggers > this occurs as the result of upgrading into 0.16.0) > > > Thanks, > > Ben Mahler > >
