----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26197/#review55019 -----------------------------------------------------------
Ship it! src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26197/#comment95352> s/try to// src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26197/#comment95351> s/wanna/want to/ src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26197/#comment95353> Perhaps include in the comment that some are shared with the host automatically and others are set to default values? src/slave/containerizer/isolators/network/port_mapping.cpp <https://reviews.apache.org/r/26197/#comment95354> Shouldn't we expect these files to exist and we should fail the container creation if they don't? - Ian Downes On Sept. 30, 2014, 3:04 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26197/ > ----------------------------------------------------------- > > (Updated Sept. 30, 2014, 3:04 p.m.) > > > Review request for mesos, Ian Downes and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/isolators/network/port_mapping.hpp > b624c4d2f2b2d635bb3fd49db46d3f23262312e4 > src/slave/containerizer/isolators/network/port_mapping.cpp > 2766a00ff81dc550c21387f920666f81705db4f0 > > Diff: https://reviews.apache.org/r/26197/diff/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >