----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26508/#review56013 -----------------------------------------------------------
src/master/flags.hpp <https://reviews.apache.org/r/26508/#comment96366> s/The value could be a/A/ ? src/master/flags.hpp <https://reviews.apache.org/r/26508/#comment96367> .. that will be loaded and accessible to augment mesos subsystems? Something that describes what happens to the input :-) src/master/flags.hpp <https://reviews.apache.org/r/26508/#comment96372> Or else what? Modules gets overwritten right? Or maybe just mentioned that you 'must not'? src/module/manager.hpp <https://reviews.apache.org/r/26508/#comment96373> Is this just a fly-by style fix? Why include module.hpp here? - Niklas Nielsen On Oct. 9, 2014, 10:19 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26508/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 10:19 a.m.) > > > Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Niklas > Nielsen. > > > Repository: mesos-git > > > Description > ------- > > Added --module flag for Mesos master. > > > Diffs > ----- > > src/common/parse.hpp e6153d8a1f25bc9ddbe1e391306beeacfc8d5ff6 > src/common/type_utils.hpp 480c0883fe6ed7f6a9daf77d83ebb077da2e66ee > src/master/flags.hpp b8b59a245523c7e7d4e04f86801ed7b023a129ea > src/master/main.cpp 018f8036b742f0b083445e03dca5c06c13d80e68 > src/module/manager.hpp 8275fd0c2f0c9ba92a9ad47f7d5d2df9295fa184 > > Diff: https://reviews.apache.org/r/26508/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
