-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26529/
-----------------------------------------------------------
(Updated Oct. 10, 2014, 2:36 p.m.)
Review request for mesos and Niklas Nielsen.
Changes
-------
Used const string instead of string literal for LD_LIBRARY_PATH.
Repository: mesos-git
Description (updated)
-------
Rename "path" in Modules protobuf to "file" since a "path" always referes to an
absolute or a relative path, whereas "file" may refer to a path or a file name.
If "file" contains a slash ("/"), it is considered an absolute or relative
path, otherwise if is considered a file name. For file name, dlopen()
automatically does a standard library path search to find the absolute path.
Also, return a better error message if an empty module name is provided.
Diffs (updated)
-----
include/mesos/module.hpp 733b1500ae3b833de4ce7585ba1b667ec164fdce
src/messages/messages.proto edf1e4ef83dfdd89f494cd215e629a304a8b84c1
src/module/manager.cpp 72041c06b28191dea244a39ba99666e53198decc
src/tests/module_tests.cpp 6f9ee33f2f2d41dcc5bde9ef6326186f56e7c7fc
Diff: https://reviews.apache.org/r/26529/diff/
Testing
-------
Added tests for LD_LIBRARY_PATH and ran make check.
Thanks,
Kapil Arya
