> On Oct. 10, 2014, 11:26 p.m., Till Toenshoff wrote: > > src/slave/main.cpp, line 117 > > <https://reviews.apache.org/r/26509/diff/5/?file=717907#file717907line117> > > > > Not yours but this would trigger a glog warning as it has not yet been > > initialized. We should possibly check all runnables for such nits at some > > point.
I was actually wrong by claiming that this would trigger a glog warning -- doublechecked it, turns out that it doesnt. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26509/#review56251 ----------------------------------------------------------- On Oct. 11, 2014, 1:25 a.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26509/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2014, 1:25 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Repository: mesos-git > > > Description > ------- > > Added --module flag for Mesos slave. > > > Diffs > ----- > > src/slave/flags.hpp 16f0cc2ab5ba16a39499608174278b3082e0585d > src/slave/main.cpp 1eafb356b58613d4ab8bd6dd245583e0d6f25a97 > > Diff: https://reviews.apache.org/r/26509/diff/ > > > Testing > ------- > > > Thanks, > > Kapil Arya > >
