----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28514/#review67202 -----------------------------------------------------------
src/watcher/whitelist_watcher.hpp <https://reviews.apache.org/r/28514/#comment111071> Can we rework this a little bit to something like: "By default the initial policy is assumed to be permissive (1), meaning that peers in-between WhitelistWatcher start and first loaded whitelist will be *accepted*. If the whitelist watcher uses a non-permissive policy ((2) or (3)), peers in-between WhitelistWatcher start and first loaded whitelist will be *denied*. In case of (1), subscribers are *only* provided with a list if a peers are subsequently loaded from the whitelist file. In case of (2) and (3), subscribers are *always* notified upfront with the initial list and subsequently, if new peers are loaded from the whitelist file." It that correctly understood and is this what your new logic does? - Niklas Nielsen On Jan. 8, 2015, 7:28 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28514/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2015, 7:28 a.m.) > > > Review request for mesos, Cody Maloney, Niklas Nielsen, and Vinod Kone. > > > Repository: mesos-git > > > Description > ------- > > The subscriber may now provide an initial whitelist and will be notified only > when the parsed whitelist differs from the initial one. The subscriber is not > explicitly notified that there is no whitelist unless they have provided a > valid initial whitelist before. This change suppresses gmock warnings for > uninteresting mock function calls. > > > Diffs > ----- > > src/watcher/whitelist_watcher.hpp 5838854 > src/watcher/whitelist_watcher.cpp 32713bb > > Diff: https://reviews.apache.org/r/28514/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.4, Ubuntu 14.04) > checked test log for gmock warnings. > > > Thanks, > > Alexander Rukletsov > >
