> On Jan. 5, 2015, 2:50 p.m., Ben Mahler wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp, lines 28-29 > > <https://reviews.apache.org/r/29533/diff/1/?file=805385#file805385line28> > > > > Is this complete? It doesn't look like it supports what we currently > > have in src/zookeeper/url.hpp: > > > > ``` > > // Describes a ZooKeeper URL of the form: > > // > > // zk://username:password@servers/path > > // > > // Where username:password is for the 'digest' scheme (see ZooKeeper > > // documentation regarding "access controls using ACLs") and servers > > // is of the form: > > // > > // host1:port1,host2:port2,host3:port3 > > // > > // Note that in the future we may want to support authentication > > // mechanisms other than 'digest' and have a URL of the following > > // form. > > // > > // zk://scheme:credentials@servers/path > > ``` > > Niklas Nielsen wrote: > Should we follow: http://tools.ietf.org/html/rfc3986 ? True URL parsing > is tricky. > > Niklas Nielsen wrote: > Or write a shim on an existing library instead of rewriting: > http://uriparser.sourceforge.net/ > > Benjamin Hindman wrote: > I was punting parsing for now and focing everyone to be explicit (which > is nice because it doesn't require dealing with a Try). I think we can pull > in a parser later. > > Also, this is a general URL, and a zookeeper::URL is a ZooKeeper URL, > which maybe we want to make be a subclass of URL? But I'm not necessarily > convinced, and didn't feel like we needed to take this on right now (people > shouldn't be converting between a zookeeper::URL and a URL anyway).
SGTM - created a ticket to keep track of using an existing library: https://issues.apache.org/jira/browse/MESOS-2247 - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29533/#review66742 ----------------------------------------------------------- On Jan. 21, 2015, 9:44 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29533/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 9:44 a.m.) > > > Review request for mesos and Ben Mahler. > > > Repository: mesos-git > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/Makefile.am > 8e51957d141af0be64cac42f65e03bca5929c8a9 > 3rdparty/libprocess/3rdparty/stout/include/stout/url.hpp PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/tests/url_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/29533/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
