> On Jan. 28, 2015, 10:17 a.m., Niklas Nielsen wrote: > > src/slave/slave.cpp, line 132 > > <https://reviews.apache.org/r/30074/diff/3/?file=828310#file828310line132> > > > > You don't have to initialize Option types with None. They will > > automatically be that :) > > Alexander Rukletsov wrote: > This is more explicit though. Do we have an agreement for such cases?
Feel free to drop - think we do both: https://github.com/apache/mesos/blob/master/src/slave/slave.cpp#L127 vs https://github.com/apache/mesos/blob/master/src/slave/slave.hpp#L406 - Niklas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30074/#review70029 ----------------------------------------------------------- On Jan. 21, 2015, 5:55 a.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30074/ > ----------------------------------------------------------- > > (Updated Jan. 21, 2015, 5:55 a.m.) > > > Review request for mesos, Niklas Nielsen and Till Toenshoff. > > > Bugs: mesos-2229 > https://issues.apache.org/jira/browse/mesos-2229 > > > Repository: mesos-git > > > Description > ------- > > Adds and entry `max_allowed_age` to the response of the stats.json endpoint > in the slave. The format of the value is `{double}(days|mins|secs)`. > > The max allowed age value is available only if it is set, which depends on > the flag `--disk_watch_interval` which by default runs every minute (So it > will only be available after the first minute running). > > Modifies the unit test `SlaveTest.MetricsInStatsEndpoint` so it takes into > account the new entry. > > > Diffs > ----- > > src/slave/http.cpp d1cf8a6 > src/slave/slave.hpp 70bd8c1 > src/slave/slave.cpp fca83b3 > src/tests/slave_tests.cpp a85a028 > > Diff: https://reviews.apache.org/r/30074/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
