> On Feb. 5, 2015, 7:38 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 1335-1353 > > <https://reviews.apache.org/r/28809/diff/4/?file=848405#file848405line1335> > > > > Is it safe to do this once on the combined resources? > > > > ``` > > Resources resources = task.resources(); > > > > if (task.has_executor()) { > > resources += task.executor().resources(); > > } > > > > foreach (const Resource& resource, resources) { > > ... > > } > > ```
It's safe, but I want to print different ERROR messages for task and executor. > On Feb. 5, 2015, 7:38 p.m., Ben Mahler wrote: > > src/slave/slave.cpp, lines 3478-3479 > > <https://reviews.apache.org/r/28809/diff/4/?file=848405#file848405line3478> > > > > It's too bad the `errors` are just unsigned ints and not a collection > > of `Option<Error>`s that we can print here. Added a TODO. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28809/#review71279 ----------------------------------------------------------- On Feb. 4, 2015, 7:13 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28809/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:13 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-2031 > https://issues.apache.org/jira/browse/MESOS-2031 > > > Repository: mesos > > > Description > ------- > > Started to maintain and checkpoint persisted resource in slave. That includes: > 1) responds to update resources message > 2) checkpoint resources > 3) recover checkpointed resources > 4) send checkpointed resources during register/reregister > > > Diffs > ----- > > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > > Diff: https://reviews.apache.org/r/28809/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
