----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29781/#review71728 -----------------------------------------------------------
Ship it! src/common/type_utils.hpp <https://reviews.apache.org/r/29781/#comment117597> s/protobufs/protobuf classes/ src/common/type_utils.hpp <https://reviews.apache.org/r/29781/#comment117603> It was most likely something in making the isolator public that forced you to expose type_utils as well. Can we find the place and reference it directly here? src/common/type_utils.hpp <https://reviews.apache.org/r/29781/#comment117598> s/ / /g - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29781/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:15 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos > > > Description > ------- > > [3/9] Build Mesos Modules outside Mesos source tree. > > This file includes definitions for operators on public protobufs > (defined in mesos.proto) that don't have these operators generated > by the protobuf compiler. The corresponding definitions are in > src/common/type_utils.cpp. > > Mesos modules need some of the protobufs defined in mesos.proto and > require some of these operators declared in type_utils.hpp. Exposing > type_utils.hpp allows us to build modules without having a dependency > on mesos source tree (src/*). > > > Diffs > ----- > > src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc > src/cli/execute.cpp 77deec91177c90a8a20ccd4fe063b82ca08cefbd > src/common/protobuf_utils.cpp c4b53a81c0426d361363c12920d67c261e381553 > src/common/type_utils.hpp b23eeb8a4055f596aba40d0c8a8250530c870876 > src/common/type_utils.cpp fcc9eb0e27a9cbf53f7923f0c051a6578527ec37 > src/examples/low_level_scheduler_libprocess.cpp > a0ec131fff1773280b17e97cb78a3da88afe6f7d > src/examples/low_level_scheduler_pthread.cpp > f05489ae10032dcf177ce149938cd94186355351 > src/examples/no_executor_framework.cpp > 5e47cfcfa1677052be114f8a9b0e24f6ef0238d9 > src/examples/test_framework.cpp 7c062dc8fbb4a48047276ecc45ec2af4ed280d6f > src/exec/exec.cpp aada24664dba9060a92230e25689c89852585443 > src/launcher/executor.cpp 1cf28f168cac6e8c7e98686a35509c2b4e052504 > src/log/coordinator.cpp fe0c5f9c55fd7a19b9c85a0860f88dd14205a631 > src/log/recover.cpp 679741b843a1df112090cd2ce2b1bc20abbbcf44 > src/log/replica.cpp dedfde4eebc12c6c4d1e75fe1f6751a56324688a > src/master/http.cpp 3981b18cb82d3b8bd974b80d27f14c304898a43c > src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30 > src/master/registrar.cpp 0831963e01e3c87bf0ac27af24b832ab2ae09d97 > src/master/validation.cpp 2c4b16df1ffe34c7e2a60a3d428242da4c20c347 > src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 > src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 > src/slave/containerizer/external_containerizer.cpp > 8d5a9047afb24a29413bfc7226f47b1edbfa4ff9 > src/slave/containerizer/isolators/cgroups/cpushare.cpp > 90aabb85da452a3a508888f738379a73b7465dc6 > src/slave/containerizer/isolators/cgroups/mem.cpp > 711d66d7771cac13be831d73af3ef570d6785473 > src/slave/http.cpp 0395d003e308f6af11242d88d7eeea104d5e47fc > src/slave/monitor.hpp f4ebafc5bbba43669dc1436899072b009936a22e > src/slave/paths.cpp 5fcfa2c78ada6f69a78fd43de067d15abb0366fa > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/slave/state.hpp f92808ad9b1623cea0c35ec735c53a3d6457bdbe > src/slave/status_update_manager.hpp > daab8e332a286ed98fd54d170853b4edcf9f915e > src/tests/flags.hpp 0d3db6cd13b898674e7e62ce90543c5834225294 > src/tests/protobuf_io_tests.cpp d5d788c32ef9d4e9434401464ed1c549b4559b38 > src/tests/registrar_tests.cpp 6bfb679d6ab07143f9c77b8cd9719a36d363645f > src/tests/state_tests.cpp ef2e96fb8b3a5e3b9c3c045b22f43f818d327b9e > > Diff: https://reviews.apache.org/r/29781/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >
