----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29606/#review71733 -----------------------------------------------------------
Ship it! src/Makefile.am <https://reviews.apache.org/r/29606/#comment117600> How about moving these to their own directory? similiary to the isolator include? - Niklas Nielsen On Feb. 4, 2015, 7:16 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29606/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:16 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos > > > Description > ------- > > [8/9] Build Mesos Modules outside Mesos source tree. > > This allows authentication modules to be built outside the mesos source tree. > > > Diffs > ----- > > src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc > src/authentication/authenticatee.hpp > 361083b5e1ca5ab1a594b3108fb768626313a725 > src/authentication/authenticator.hpp > 460494a49ad7c71803507afe62005280d5929d41 > src/authentication/cram_md5/authenticatee.hpp > 5d35598f75f4d9a8c185cfd387e1085b3bf15395 > src/authentication/cram_md5/authenticator.hpp > d739a02d755c2729248291db8c274ad7e7dd4c6d > src/examples/test_authentication_modules.cpp > 6d32573d4e7817ddb62f3eb7aca2cf3f06d27c65 > src/master/master.hpp dcfd38ae2fa9e1bd0b477e9719724dba37114d30 > src/master/master.cpp 234bbecc4205036d790b026abd59100eb188f913 > src/module/authenticatee.hpp bae37ced0b5da5dec2ff91d795cc8e75fd8900f2 > src/module/authenticator.hpp 956233852c355f67b890479b7330d2d2f01dbaf3 > src/sched/sched.cpp a822c002781b35872d3c477366775a3705343cd2 > src/scheduler/scheduler.cpp 44713cae36a83081c9a665d2eb73f9dbec2d4268 > src/slave/slave.hpp 70bd8c1fde4ea09fa54c76aa93424a1adb0309f6 > src/slave/slave.cpp a8b262174ab5c9a524db8318d3d1438cd75a702b > src/tests/cram_md5_authentication_tests.cpp > a356aa1fbcf5492b22e78bd4e7ee1d092f5cf736 > > Diff: https://reviews.apache.org/r/29606/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Kapil Arya > >
