----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29603/#review71743 -----------------------------------------------------------
Ship it! - Niklas Nielsen On Feb. 4, 2015, 7:15 p.m., Kapil Arya wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29603/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2015, 7:15 p.m.) > > > Review request for mesos, Niklas Nielsen, Till Toenshoff, and Timothy Chen. > > > Bugs: MESOS-2096 > https://issues.apache.org/jira/browse/MESOS-2096 > > > Repository: mesos > > > Description > ------- > > [5/9] Build Mesos Modules outside Mesos source tree. > > Expose "slave/state.hpp" and "slave/containerizer/isolator.hpp" to allow > modules to include them directly from the Mesos install location. > > > Diffs > ----- > > src/Makefile.am 93537d17d3c7604a8532ee1453e405630c481ddc > src/examples/test_isolator_module.cpp > dc107a1315271b0275c60819c4b5aaa1f527e73c > src/module/isolator.hpp 0f71e700ed2de20bdc9a1fdad087005a14e208a8 > src/slave/containerizer/containerizer.cpp > 421bb868b353e644578fa27f04bdd636bfc89134 > src/slave/containerizer/external_containerizer.hpp > 8363cec490a2918e08a8d30d9b8832fd1e2dd4f5 > src/slave/containerizer/isolator.hpp > a27c3e955ff25b87599af0ac2c97427a88b786f6 > src/slave/containerizer/isolator.cpp > 90a47c4fc8ce2d1a2aa09fa9ad905b76eab74c80 > src/slave/containerizer/isolators/cgroups/cpushare.hpp > 4ded0c4678ad61742a69e14233006a448f3fc3ca > src/slave/containerizer/isolators/cgroups/mem.hpp > 2fa755571b4d21b8b13301fcfd57ae05ea66e6e6 > src/slave/containerizer/isolators/cgroups/perf_event.hpp > e511c3efe4cc4ec13cc74bdcda993477a4db2e36 > src/slave/containerizer/isolators/filesystem/shared.hpp > 727f63e16fa69293c472a4b6b95fb0be04e689c8 > src/slave/containerizer/isolators/namespaces/pid.hpp > 8da6cccff04edf11fa37f5a33648821299cf49d5 > src/slave/containerizer/isolators/network/port_mapping.hpp > 90d19a95092bc18c1077fbaec9ebf9c87291474c > src/slave/containerizer/isolators/posix.hpp > 7a667e3e30712b98484947520b58965d3b768659 > src/slave/containerizer/isolators/posix/disk.hpp > cf4e143eb50cf5ee59ca0d47dd6f8d0a845c3732 > src/slave/containerizer/launcher.hpp > 18b3546a5e51e8a3819bca11630f699a0aadf762 > src/slave/containerizer/mesos/containerizer.hpp > 569119fc591ecb118ecff51b8b19d0a1b8090cb5 > src/slave/containerizer/mesos/containerizer.cpp > d712278428889ebdfd598537690138329d8464f0 > src/tests/containerizer_tests.cpp cfe31a6b528ec44c5f4ff9eaf453c68d9e518db4 > src/tests/isolator.hpp 2c3a694fade996df6fb679e78f96876a7d32d214 > src/tests/isolator_tests.cpp 1f1c26d4a8faf6fcea822fccc00bb58a478285f8 > src/tests/module_tests.cpp df30e169a1e9ee2e6c419ba30612d55328e3adbc > src/tests/port_mapping_tests.cpp 18d58ff310d189f7461eead445e186172cbcd101 > > Diff: https://reviews.apache.org/r/29603/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Kapil Arya > >