> On Feb. 12, 2015, 5:41 p.m., Ben Mahler wrote: > > src/slave/containerizer/mesos/containerizer.hpp, line 280 > > <https://reviews.apache.org/r/30906/diff/1/?file=861366#file861366line280> > > > > Should this just be "mesos_containerizer/launcher_destroy_errors"? > > Looking at our port_mapping/ metrics, and other subcomponent metrics, that > > seems like a more consistent name? > > Ben Mahler wrote: > Or, is it possible to have this error in the launcher and just call it: > "launcher/destroy_errors" or "linux_launcher/destroy_errors"?
Or we can modify port_mapping metrics to be `slave/containerizer/mesos/isolators/network/port_mapping/xxx`. Maybe that's too long? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30906/#review72190 ----------------------------------------------------------- On Feb. 12, 2015, 1:34 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30906/ > ----------------------------------------------------------- > > (Updated Feb. 12, 2015, 1:34 a.m.) > > > Review request for mesos, Ian Downes and Jie Yu. > > > Bugs: MESOS-1690 > https://issues.apache.org/jira/browse/MESOS-1690 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.hpp > 074a2d82dcd882e52f8cd62ed7493295596acb26 > src/slave/containerizer/mesos/containerizer.cpp > d5b90d12d63becfeb4c3efa9c6f5d826417f582c > > Diff: https://reviews.apache.org/r/30906/diff/ > > > Testing > ------- > > make check > > No existing launcher tests to inject metrics test. Will work with @idownes to > figure how to write one. > > > Thanks, > > Vinod Kone > >
