----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31263/#review75970 -----------------------------------------------------------
src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/31263/#comment123322> Can you add a comment about why you don't return a pointer here? src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/31263/#comment123323> s/!// src/tests/master_allocator_tests.cpp <https://reviews.apache.org/r/31263/#comment123326> We need a default value for testAllocator src/tests/mesos.hpp <https://reviews.apache.org/r/31263/#comment123328> Do you want to have: CHECK_NOTNULL(allocator->real)->initialize(arg0, arg1, arg2); ? src/tests/mesos.hpp <https://reviews.apache.org/r/31263/#comment123332> Let's see if we can merge the two constructors src/tests/mesos.hpp <https://reviews.apache.org/r/31263/#comment123336> With one constructor, we could get rid of this helper. src/tests/mesos.hpp <https://reviews.apache.org/r/31263/#comment123334> Can you reintroduce this destructor? - Niklas Nielsen On March 5, 2015, 1:11 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31263/ > ----------------------------------------------------------- > > (Updated March 5, 2015, 1:11 p.m.) > > > Review request for mesos, Kapil Arya, Michael Park, and Niklas Nielsen. > > > Bugs: MESOS-2160 > https://issues.apache.org/jira/browse/MESOS-2160 > > > Repository: mesos > > > Description > ------- > > TestAllocator stores a pointer to a real allocator and takes over its > ownership. MasterAllocatorTest fixture stores the test allocator in turn. > > > Diffs > ----- > > src/tests/containerizer.cpp 26b87ac6b16dfeaf84888e80296ef540697bd775 > src/tests/master_allocator_tests.cpp > a432d0207e1a92532a495bf9ad2826414ee4f6f0 > src/tests/mesos.hpp 45e35204d1aa876fa0c871acf0f21afcd5ababe8 > src/tests/resource_offers_tests.cpp > 882a9ff4d09aace486182828bf43b643b0d0c519 > src/tests/slave_recovery_tests.cpp 53adae0118a26e6d25a9ff20c6374cc8e73275b1 > > Diff: https://reviews.apache.org/r/31263/diff/ > > > Testing > ------- > > make check (Mac OS 10.9.5, Ubuntu 14.04) > > > Thanks, > > Alexander Rukletsov > >
