----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31905/#review76084 -----------------------------------------------------------
src/common/type_utils.cpp <https://reviews.apache.org/r/31905/#comment123489> So we are ignoring CommandInfo::ContainerInfo because it's being deprecated? If yes, could you please add a NOTE here? src/common/type_utils.cpp <https://reviews.apache.org/r/31905/#comment123488> Kill the extra line here. src/common/type_utils.cpp <https://reviews.apache.org/r/31905/#comment123493> Looks like we have the same logic for many repeated fields here. I am wondering if we can have a helper function: ``` template <typename T> bool equivalent( const RepeatedField<T>& left, const RepeatedField<T>& right, bool checkOrder = false) { if (left.size() != right.size()) { return false; } for (int i = 0; i < left.size(); i++) { ... } ... } ``` - Jie Yu On March 11, 2015, 12:37 a.m., Vinod Kone wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31905/ > ----------------------------------------------------------- > > (Updated March 11, 2015, 12:37 a.m.) > > > Review request for mesos, Ben Mahler, Jie Yu, Joerg Schad, and Timothy Chen. > > > Bugs: MESOS-2309 > https://issues.apache.org/jira/browse/MESOS-2309 > > > Repository: mesos > > > Description > ------- > > When new fields were added to protobufs these operators were not updated. > Fixed now. > > > Diffs > ----- > > src/common/type_utils.cpp a1704c67d04d19f65d94dbe56a61bb28561e5bf3 > > Diff: https://reviews.apache.org/r/31905/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Vinod Kone > >
