-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32426/
-----------------------------------------------------------

Review request for mesos, Chi Zhang, Ian Downes, and Vinod Kone.


Bugs: MESOS-2528
    https://issues.apache.org/jira/browse/MESOS-2528


Repository: mesos


Description
-------

Symlink the namespace handle with ContainerID for the port mapping isolator.

See ticket for details. This patch will allow a smooth upgrade (i.e., rolling 
foward and back are both safe).


Diffs
-----

  src/slave/containerizer/isolators/network/port_mapping.hpp 
4dd066a47d43cb1d52f93294d86309151738743e 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
4bf0adeeac1cb6fe59f9c2ca8d5980b1500f5ddd 
  src/tests/port_mapping_tests.cpp 8192deac8d9b7ea1896bb62a8b5961ef90326fa4 

Diff: https://reviews.apache.org/r/32426/diff/


Testing
-------

sudo make check

Many existing tests should already capture the regression. For example, 
ROOT_CleanUpOrphanTest checks if the bind mount dir is empty after the 
container is destroyed.

Will add a compatibility test tomorrow.


Thanks,

Jie Yu

Reply via email to