Hi Zhiwei, I was thinking about this as well, but for different reasons: Pulling in Docker images for tests is not the ideal solution. Sure, testing a `sleep 1000` should work, but testing an executor leaves some questions on how to handle changes/deprecation of the interfaces. It's not a pressing issue right now, but might become one in the future.
I think this is also what Timothy had in mind with his comment (Timothy, please correct me if I'm wrong): These problems can be resolved by using local Docker images, ideally ones that are created during `make check`. But this would create new problems. Either we would have to build libmesos inside our local container -- to be able to build test executors -- which would take a long time, or we'd have to make sure that the container environment is the same as the dev environment, to be able to copy test executors into it, which isn't easy unless we'd restrict ourselves to only a couple of environments. Cheers, Jan On Thu, Mar 10, 2016 at 11:25 AM, zhiwei <zhiw...@gmail.com> wrote: > Hi all, > > The Docker related test cases that hardcoded "alpine" as the Docker image > which caused test cases failed on IBM Power platform, since the Docker > image "alpine" is not compatible with IBM Power platform. > > And I saw an inline comment by Timothy: "// TODO(tnachen): Use local image > to test if possible." > > So just wonder if someone has plan to implement this, or could you give me > some tips? I can implement this. > > Following are the images that used in Mesos test cases: > > 1. alpine > 2. mesosphere/alpine-expect > 3. mesosphere/inky > 4. mesosphere/test-executor > 5. tnachen/test-executor > > > Thanks, > Zhiwei > -- *Jan Schlicht* Distributed Systems Engineer, Mesosphere
