@vinod, @alexr. Neil and I had also suggested not excluding the doc directories (which Yong's current patch still does). What are your thoughts on this?
On Fri, Apr 1, 2016 at 6:47 PM, Yong Tang <yong.tang.git...@outlook.com> wrote: > Hi Vinod, > > Thanks for the help. I updated the mesos-style.py and added the non-ascii > check there. > > Please let me know if there is anything else that needs to do to move forward > this issue. > > > Thanks > Yong > >> From: vinodk...@apache.org >> Date: Fri, 1 Apr 2016 15:47:29 -0700 >> Subject: Re: Looking for Shepherd for MESOS-4033 (commit hook for non-ascii >> characters) >> To: dev@mesos.apache.org >> >> @AleR do you want to be a shepherd for this, since you originally filed >> this ticket? >> >> @Yong: Just took a quick look at the review. It's unfortunate that we need >> a whole new script for checking non-ascii characters. Can we update >> mesos-style.py to catch this? >> >> On Fri, Apr 1, 2016 at 7:36 AM, Yong Tang <yong.tang.git...@outlook.com> >> wrote: >> >> > Ping again to find a shepherd for MESOS-4033. A review request has been >> > created with good discussions from many reviewers: >> > >> > https://reviews.apache.org/r/45033/ >> > >> > It would be really good if a shepherd could provide some guidance so that >> > this ticket could move forward. >> > >> > Thanks >> > Yong >> > >> > > Date: Sat, 26 Mar 2016 08:13:28 +0800 >> > > Subject: Re: Looking for Shepherd for MESOS-4033 (commit hook for >> > non-ascii characters) >> > > From: xia...@gmail.com >> > > To: dev@mesos.apache.org >> > > >> > > +1 >> > > >> > > 2016-03-25 23:26 GMT+08:00 Yong Tang <yong.tang.git...@outlook.com>: >> > > >> > > > Hi >> > > > >> > > > Just bump the email to look for shepherd for MESOS-4033. >> > > > >> > > > This issue (commit hook for non ascii characters) has already been >> > fairly >> > > > discussed on the review board. Thanks Deshi, Neil, and haosdent for the >> > > > great inputs. >> > > > >> > > > It really would be nice if there is anyone that could shepherd so that >> > the >> > > > issue could move forward. >> > > > >> > > > Thanks >> > > > Yong >> > > > >> > > > >> > > > > From: yong.tang.git...@outlook.com >> > > > > To: dev@mesos.apache.org >> > > > > Subject: Looking for Shepherd for MESOS-4033 (commit hook for >> > non-ascii >> > > > characters) >> > > > > Date: Tue, 22 Mar 2016 08:31:40 -0700 >> > > > > >> > > > > Hi All >> > > > > >> > > > > Can anyone help shepherd MESOS-4033 - Add a commit hook for non-ascii >> > > > characters? >> > > > > >> > > > > https://issues.apache.org/jira/browse/MESOS-4033 >> > > > > >> > > > > This issue is about adding a commit hook to check for non-ascii >> > > > characters. The issue has been accepted sometime ago. >> > > > > >> > > > > Thanks a lot for the help >> > > > > Yong >> > > > > >> > > > >> > > > >> > > >> > > >> > > >> > > -- >> > > Deshi Xiao >> > > Twitter: xds2000 >> > > E-mail: xiaods(AT)gmail.com >> > >> > > -- ~Kevin
