AFAICT, this shouldn't break anything, since by omitting the syntax specification we're effectively setting it to the default, "proto2". As a quick test, I added `syntax = "proto2";` to the top of mesos.proto, built Mesos, and then ran some tests - it seems to work fine!
Greg On Tue, Sep 6, 2016 at 12:50 PM, Zhitao Li <zhitaoli...@gmail.com> wrote: > Hi all, > > Does anyone see what could break if we add a line "syntax=proto2" to every > public .proto files in Mesos codebase? > > Some of our internal project compiles against Mesos and we are manually > adding this line because we also uses proto3 for internal files, and this > is necessary for protoc to work correctly. It'll be better if this can be > added upstream. > > This is not really urgent or blocker, just something nice to have. > > Thanks! > > -- > Cheers, > > Zhitao Li >
