Github user jdef commented on a diff in the pull request:

    https://github.com/apache/mesos/pull/248#discussion_r148790566
  
    --- Diff: src/master/validation.cpp ---
    @@ -350,12 +353,13 @@ Option<Error> reregisterSlave(
         }
     
         if (executor.has_executor_id()) {
    -      if (executorIDs.contains(executor.executor_id())) {
    +      IDPair fep = IDPair(executor.framework_id(), executor.executor_id());
    --- End diff --
    
    already got feedback that `fep` is probably not a good choice for a name 
here


---

Reply via email to