Gili created SSHD-1299: -------------------------- Summary: CoreModuleProperties.NIO2_MIN_WRITE_TIMEOUT name is misleading Key: SSHD-1299 URL: https://issues.apache.org/jira/browse/SSHD-1299 Project: MINA SSHD Issue Type: Bug Affects Versions: 2.9.1 Reporter: Gili
CoreModuleProperties.NIO2_MIN_WRITE_TIMEOUT is documented as "Minimum NIO2 write wait timeout for a single outgoing packet - in milliseconds" but if you look at the implementation of Nio2Session.doWriteCycle, it is used as the second parameter of socket.write(). This parameter (timeout) is documented as "The maximum time for the I/O operation to complete" Hence, I would expect the parameter name to contain MAX not MIN, and the Javadoc should explain this value corresponds to the *maximum* amount of time to wait for a write to complete. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org