[ 
https://issues.apache.org/jira/browse/DIRMINA-1122?focusedWorklogId=861080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-861080
 ]

ASF GitHub Bot logged work on DIRMINA-1122:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 08/May/23 20:58
            Start Date: 08/May/23 20:58
    Worklog Time Spent: 10m 
      Work Description: elecharny commented on PR #26:
URL: https://github.com/apache/mina/pull/26#issuecomment-1539039335

   On the test, we use a custom SSLFilter which sets the peer:
   
   ```
           protected SSLEngine createEngine(IoSession session, 
InetSocketAddress addr) {
               //Add your SNI host name and port in the IOSession
               String sniHostNames = (String)session.getAttribute( 
"SNIHostNames" );
               int portNumber = (int)session.getAttribute( "PortNumber");
               InetSocketAddress peer = InetSocketAddress.createUnresolved( 
sniHostNames, portNumber);
               
               SSLEngine sslEngine = (addr != null) ?
                   sslContext.createSSLEngine(peer.getHostString(), 
peer.getPort()) : sslContext.createSSLEngine();
   ...
   ```
   
   The default ```SslFilter.createEngine()``` never get called when 
initializing the  **Connector**. 
   
   It's called only for the **Acceptor**.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 861080)
    Time Spent: 1h 50m  (was: 1h 40m)

> Add support for endpoint identification algorithm
> -------------------------------------------------
>
>                 Key: DIRMINA-1122
>                 URL: https://issues.apache.org/jira/browse/DIRMINA-1122
>             Project: MINA
>          Issue Type: Improvement
>          Components: Filter, SSL
>    Affects Versions: 2.0.22, 2.1.3
>            Reporter: Marcin L
>            Assignee: Jonathan Valliere
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: 
> DIRMINA-1122_-_endpoint_identification_algorithm_support.patch
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> Support for endpoint identification algorithm was added in Java 1.7. 
> Currently MINA supports providing single SNI name via 
> org.apache.mina.filter.ssl.SslFilter#PEER_ADDRESS session attribute, but 
> there is no way verifying it matches the certificate received.
> It would be nice if we could provide endpoint identification algorithm to 
> SslFilter so certificate's common name or subject alternative names are 
> verified.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to