tomaswolf commented on PR #372: URL: https://github.com/apache/mina-sshd/pull/372#issuecomment-1565697931
Thanks for this fix. Unfortunately tests are failing. A quick fix might be to open the channel for writing in that failing test method. But it seems that the locking implementation doesn't map exceptions correctly when channels are opened for reading only (server just returns a "General Failure"); surely that could be improved. And moreover, the javadoc on `FileChannel.lock()` says a `NonWritableChannelException` should be thrown if the channel wasn't writeable. It should be possible to check that on the client side before even making any remote call. We have no tests for other combinations (read lock on a write-only channel). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
