Hi All:

+1

I am reviewing the src zip file:

- ASC OK

- Can't validate SHA file with:
    shasum --check apache-sshd-2.11.0-src.zip.sha512
  This is due to non-standard format for the file.
  Eyeballing the file looks OK when compared to shasum -a 512 output.

- IMO, the VOTE email should include a link to the KEYS file. 
  The KEYS file is not even listed on 
https://mina.apache.org/sshd-project/downloads.html
  I had to go hunt for it: https://dist.apache.org/repos/dist/release/mina/KEYS

- Non-Blocker: Can't we just have SHA-512, instead of both SHA-512 and SHA-256?

- There is no way that I can tell if we've broken binary compatibility (or 
source compatibility) since there is no use of japicmp (or revapi or ...)

- mvn apache-rat:check OK

- mvn clean install OK

- Using:
Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)
Maven home: C:\java\apache-maven-3.9.5
Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program 
Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
Default locale: en_US, platform encoding: Cp1252
OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"

Gary


On 2023/10/12 14:33:37 Guillaume Nodet wrote:
> I've staged a candidate release for 2.11.0 at:
> Official staging repo:
>   https://dist.apache.org/repos/dist/dev/mina/sshd/2.11.0/
> Maven staging repo:
>   https://repository.apache.org/content/repositories/orgapachemina-1089
> Git tag:
>   https://github.com/apache/mina-sshd/commits/sshd-2.11.0
> Changelog:
> 
> https://github.com/apache/mina-sshd/blob/sshd-2.11.0/docs/changes/2.11.0.md
> 
> Please review and vote !
> 
> 
> -- 
> ------------------------
> Guillaume Nodet
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org
For additional commands, e-mail: dev-h...@mina.apache.org

Reply via email to