kllbzz commented on PR #41: URL: https://github.com/apache/mina/pull/41#issuecomment-1786199195
@elecharny thanks for reply. > The rational is that teh _SslFilter_ can be added on the fly on an opened session, so removing the call to _onConnected_ in the _onPostAdd_ will defeat this feature. OTOH, if we remove the call to the _onConnect_ method in the _sessionOpened_ method, it should work as exepcted. Actually, removing onConnected (handshake) from __onPostAdd__ will force everyone who need this to override SslFilter. I'm mentionting this because this is was done in quickfix for previous version of mina but in opposit direction. Old SslFilter has flag 'autostart' and quickfix put it to false when connection is made via proxy, and called sslFilter.handshake manually after connection to proxy established. > > Can you check with the removal of the _onConnected_ call in the _sessionOpened_ method? > Sorry, I don't understand how it can help to prevent exception during filter chain creation. Session open event is sent after all filters are added (all preAdd postAdd called). Probably what I will do is what was done in prevouse quickfix version, override SslFilter to not call handshake in preAdd if connection done via proxy (aka old 'autostart' flag). Or if you are ok we can revert back 'autostart' (autohandshake flag) flag in mina ? I'm not often user of mina, but it seems static filters config is more natural usecase (opposit to adding filters dynamically) ? But I believe you are not welcome changes in old branches If there is workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@mina.apache.org For additional commands, e-mail: dev-h...@mina.apache.org
